qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] scripts: update (rewrite) qemu-binfmt-conf.h


From: Laurent Vivier
Subject: Re: [Qemu-devel] [PATCH] scripts: update (rewrite) qemu-binfmt-conf.h
Date: Sat, 30 May 2015 21:51:23 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0


Le 30/05/2015 21:32, Peter Maydell a écrit :
> On 30 May 2015 at 20:28, Laurent Vivier <address@hidden> wrote:
>> Orginal qemu-binfmt-conf.h is only able to write configuration
>> into /proc/sys/fs/binfmt_misc, and the configuration is lost on reboot.
>>
>> This script can configure debian and systemd services to restore
>> configuration on reboot. Moreover, it is able to manage binfmt
>> credential and to configure the path of the interpreter.
> 
> 
>> +i386_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x03\x00'
>> +i386_mask='\xff\xff\xff\xff\xff\xfe\xfe\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
>> +i386_family=i386
> 
> Personally I think it would be nice to store these in
> update-binfmts(8) style format files rather than directly
> in the script. That way we separate data from the
> implementation, and it's convenient if you want to do
> something else with the data than what the script does.

To separate data and implementation was my idea 2 years ago:
https://patchwork.ozlabs.org/patch/213887/
https://patchwork.ozlabs.org/patch/213886/

but it is easier to manage if all stuffs are in the same file.

The first idea is to keep compatibility of the original script by adding
only features. As I'd like to have a script working on
debian/fedora(suse?)/generic, we must keep the base format as simple as
possible. With this format, we are able to generate easily
update-binfmts format, systemd-binfmt.service format or to write
directly into /proc.

Regards,
Laurent





reply via email to

[Prev in Thread] Current Thread [Next in Thread]