qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC v2 10/34] include/exec: Split target_long def to n


From: Richard Henderson
Subject: Re: [Qemu-devel] [RFC v2 10/34] include/exec: Split target_long def to new header
Date: Mon, 01 Jun 2015 13:32:57 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 06/01/2015 12:51 PM, Paolo Bonzini wrote:


On 01/06/2015 21:24, Richard Henderson wrote:
On 05/30/2015 11:11 PM, Peter Crosthwaite wrote:
This is currently provided by cpu-defs and is a target specific
definition. However, to prepare for multi-arch only the bare minimum
content from cpu-defs.h should be exported to core code. And this is
all we need. So split it to a new header that the target_multi cpu.h
can include to save on having to include the ill-defined cpu-defs.h.

Allow multiple inclusion for multi-arch where multiple cpu.h's need
to be included and target_long will vary for each.

Signed-off-by: Peter Crosthwaite <address@hidden>
---
  include/exec/cpu-defs.h    | 23 +-------------------
  include/exec/target-long.h | 52 ++++++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 53 insertions(+), 22 deletions(-)
  create mode 100644 include/exec/target-long.h

Multiple inclusion with a typedef?  How's that supposed to work?

He later #defines target_{,u}long to e.g. arm_target_{,u}long.

Ok, here's where I'm not liking things. It shouldn't be a typedef in some places and a define others. From this description, it sounds like it ought to always be a define.


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]