Re: [Qemu-devel] [PATCH 05/12] audio: expose drv_opaque to init_out and init_in

[Gerd Hoffmann]

On Di, 2015-06-02 at 12:03 +0200, Kővágó Zoltán wrote:
> 2015-06-02 09:56 keltezéssel, Gerd Hoffmann írta:
> >> -static int alsa_init_out (HWVoiceOut *hw, struct audsettings *as)
> >> +static int alsa_init_out(HWVoiceOut *hw, struct audsettings *as,
> >> +                         void *drv_opaque)
> >>   {
> >>       ALSAVoiceOut *alsa = (ALSAVoiceOut *) hw;
> >>       struct alsa_params_req req;
> >> @@ -827,6 +828,8 @@ static int alsa_init_out (HWVoiceOut *hw, struct 
> >> audsettings *as)
> >>       snd_pcm_t *handle;
> >>       struct audsettings obt_as;
> >>
> >> +    (void) drv_opaque;
> >> +
> >
> > What is the reason for this?
> 
> To silence compiler warnings about unused variables.

That should not happen for parameters (only for local variables).

> I've seen it around 
> different places in the code. But if they are just historic remains, 
> I'll remove them.

Yes, please.

thanks,
  Gerd