[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/11] xen/pt: consolidate PM capability emu_mask
From: |
Stefano Stabellini |
Subject: |
[Qemu-devel] [PULL 05/11] xen/pt: consolidate PM capability emu_mask |
Date: |
Tue, 2 Jun 2015 16:40:22 +0100 |
From: Jan Beulich <address@hidden>
There's no point in xen_pt_pmcsr_reg_{read,write}() each ORing
PCI_PM_CTRL_STATE_MASK and PCI_PM_CTRL_NO_SOFT_RESET into a local
emu_mask variable - we can have the same effect by setting the field
descriptor's emu_mask member suitably right away. Note that
xen_pt_pmcsr_reg_write() is being retained in order to allow later
patches to be less intrusive.
This is a preparatory patch for XSA-131.
Signed-off-by: Jan Beulich <address@hidden>
Acked-by: Stefano Stabellini <address@hidden>
Acked-by: Ian Campbell <address@hidden>
---
hw/xen/xen_pt_config_init.c | 25 ++++---------------------
1 file changed, 4 insertions(+), 21 deletions(-)
diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
index 436d0fd..516236a 100644
--- a/hw/xen/xen_pt_config_init.c
+++ b/hw/xen/xen_pt_config_init.c
@@ -933,38 +933,21 @@ static XenPTRegInfo xen_pt_emu_reg_pcie[] = {
* Power Management Capability
*/
-/* read Power Management Control/Status register */
-static int xen_pt_pmcsr_reg_read(XenPCIPassthroughState *s, XenPTReg
*cfg_entry,
- uint16_t *value, uint16_t valid_mask)
-{
- XenPTRegInfo *reg = cfg_entry->reg;
- uint16_t valid_emu_mask = reg->emu_mask;
-
- valid_emu_mask |= PCI_PM_CTRL_STATE_MASK | PCI_PM_CTRL_NO_SOFT_RESET;
-
- valid_emu_mask = valid_emu_mask & valid_mask;
- *value = XEN_PT_MERGE_VALUE(*value, cfg_entry->data, ~valid_emu_mask);
-
- return 0;
-}
/* write Power Management Control/Status register */
static int xen_pt_pmcsr_reg_write(XenPCIPassthroughState *s,
XenPTReg *cfg_entry, uint16_t *val,
uint16_t dev_value, uint16_t valid_mask)
{
XenPTRegInfo *reg = cfg_entry->reg;
- uint16_t emu_mask = reg->emu_mask;
uint16_t writable_mask = 0;
uint16_t throughable_mask = 0;
- emu_mask |= PCI_PM_CTRL_STATE_MASK | PCI_PM_CTRL_NO_SOFT_RESET;
-
/* modify emulate register */
- writable_mask = emu_mask & ~reg->ro_mask & valid_mask;
+ writable_mask = reg->emu_mask & ~reg->ro_mask & valid_mask;
cfg_entry->data = XEN_PT_MERGE_VALUE(*val, cfg_entry->data, writable_mask);
/* create value for writing to I/O device register */
- throughable_mask = ~emu_mask & valid_mask;
+ throughable_mask = ~reg->emu_mask & valid_mask;
*val = XEN_PT_MERGE_VALUE(*val, dev_value, throughable_mask);
return 0;
@@ -1000,9 +983,9 @@ static XenPTRegInfo xen_pt_emu_reg_pm[] = {
.size = 2,
.init_val = 0x0008,
.ro_mask = 0xE1FC,
- .emu_mask = 0x8100,
+ .emu_mask = 0x810B,
.init = xen_pt_common_reg_init,
- .u.w.read = xen_pt_pmcsr_reg_read,
+ .u.w.read = xen_pt_word_reg_read,
.u.w.write = xen_pt_pmcsr_reg_write,
},
{
--
1.7.10.4
- [Qemu-devel] [PULL 0/11] Xen PCI Passthrough security fixes, Stefano Stabellini, 2015/06/02
- [Qemu-devel] [PULL 08/11] xen/pt: mark all PCIe capability bits read-only, Stefano Stabellini, 2015/06/02
- [Qemu-devel] [PULL 06/11] xen/pt: correctly handle PM status bit, Stefano Stabellini, 2015/06/02
- [Qemu-devel] [PULL 10/11] xen/pt: add a few PCI config space field descriptions, Stefano Stabellini, 2015/06/02
- [Qemu-devel] [PULL 02/11] xen: don't allow guest to control MSI mask register, Stefano Stabellini, 2015/06/02
- [Qemu-devel] [PULL 01/11] xen: properly gate host writes of modified PCI CFG contents, Stefano Stabellini, 2015/06/02
- [Qemu-devel] [PULL 05/11] xen/pt: consolidate PM capability emu_mask,
Stefano Stabellini <=
- [Qemu-devel] [PULL 03/11] xen/MSI-X: limit error messages, Stefano Stabellini, 2015/06/02
- [Qemu-devel] [PULL 09/11] xen/pt: mark reserved bits in PCI config space fields, Stefano Stabellini, 2015/06/02
- [Qemu-devel] [PULL 07/11] xen/pt: split out calculation of throughable mask in PCI config space handling, Stefano Stabellini, 2015/06/02
- [Qemu-devel] [PULL 04/11] xen/MSI: don't open-code pass-through of enable bit modifications, Stefano Stabellini, 2015/06/02
- [Qemu-devel] [PULL 11/11] xen/pt: unknown PCI config space fields should be read-only, Stefano Stabellini, 2015/06/02
- Re: [Qemu-devel] [PULL 0/11] Xen PCI Passthrough security fixes, Peter Maydell, 2015/06/02