qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 06/10 v11] target-tilegx: Add special register i


From: Chen Gang
Subject: Re: [Qemu-devel] [PATCH 06/10 v11] target-tilegx: Add special register information from Tilera Corporation
Date: Wed, 3 Jun 2015 04:53:14 +0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 6/3/15 01:44, Peter Maydell wrote:
> On 30 May 2015 at 22:15, Chen Gang <address@hidden> wrote:
>> The related copy is from Linux kernel "arch/tile/include/uapi/arch/
>> spr_def_64.h".
>>
>> Signed-off-by: Chen Gang <address@hidden>
>> ---
>>  target-tilegx/spr_def_64.h | 216 
>> +++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 216 insertions(+)
>>  create mode 100644 target-tilegx/spr_def_64.h
> 
> I'd care more about the possibility of conflicts with the
> actual user header if we supported building QEMU on
> a tilegx host. But since we don't this is OK.
> 

it contents "#ifndef __ARCH_SPR_DEF_64_H__", and belongs to UAPI which
should be no changes (at least should be compatible with old version),
so for me, it should be no conflicts on a tilegx host.

> Reviewed-by: Peter Maydell <address@hidden>
> 

OK Thanks.

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed



reply via email to

[Prev in Thread] Current Thread [Next in Thread]