Re: [Qemu-devel] [PATCH 1/3] migration: Remove duplicated assignement of SETUP status

[Juan Quintela]

John Snow <address@hidden> wrote:
> On 05/20/2015 11:58 AM, Eric Blake wrote:
>> On 05/20/2015 09:35 AM, Juan Quintela wrote:
>>> We assign the MIGRATION_STATUS_SETUP status in two places.  Just
>>> in sucession.  Just remove the second one.
>> 
>> s/sucession/succession/
>> 
>
> Also s/assignement/assignment/ in the subject.
>
>> Where's the second place? Not in migrate_fd_connect...
>> 
>> okay, migrate_init() does the same thing, and I guess you're
>> arguing that it was always called either just before or just after 
>> migrate_fd_connect can be called. But mentioning it in the commit 
>> message would help.
>> 
>>> 
>>> Signed-off-by: Juan Quintela <address@hidden> --- 
>>> migration/migration.c | 3 --- 1 file changed, 3 deletions(-)
>>> 
>> 
>> Reviewed-by: Eric Blake <address@hidden>
>> 

Thanks to both of you.

Later, Juan.