qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 14/38] block: Move BlockAcctStats into BlockB


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 14/38] block: Move BlockAcctStats into BlockBackend
Date: Wed, 03 Jun 2015 14:52:34 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 06/03/2015 01:43 PM, Max Reitz wrote:
> As the comment above bdrv_get_stats() says, BlockAcctStats is something
> which belongs to the device instead of each BlockDriverState. This patch
> therefore moves it into the BlockBackend.

Again, Berto may want to eventually report stats for both BDS and BB,
but that can come later.  For now, this is reasonable refactoring.

> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  block.c                   | 11 -----------
>  block/block-backend.c     |  5 ++++-
>  block/io.c                |  6 +++++-
>  block/qapi.c              | 24 ++++++++++++++----------
>  include/block/block.h     |  2 --
>  include/block/block_int.h |  3 ---
>  6 files changed, 23 insertions(+), 28 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]