[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 33/38] qmp: Introduce blockdev-change-medium
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 33/38] qmp: Introduce blockdev-change-medium |
Date: |
Wed, 03 Jun 2015 15:37:04 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/03/2015 01:44 PM, Max Reitz wrote:
> Introduce a new QMP command 'blockdev-change-medium' which is intended
> to replace the 'change' command for block devices. The existing function
> qmp_change_blockdev() is accordingly renamed to
> qmp_blockdev_change_medium().
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> blockdev.c | 7 ++++---
> include/sysemu/blockdev.h | 2 --
> qapi-schema.json | 6 ++++--
> qapi/block-core.json | 23 +++++++++++++++++++++++
> qmp-commands.hx | 31 +++++++++++++++++++++++++++++++
> qmp.c | 2 +-
> 6 files changed, 63 insertions(+), 8 deletions(-)
>
> +++ b/qapi/block-core.json
> @@ -1909,6 +1909,29 @@
>
>
> ##
> +# @blockdev-change-medium:
> +#
> +# Changes the medium inserted into a block device by ejecting the current
> medium
> +# and loading a new image file which is inserted as the new medium (this
> command
> +# combines blockdev-open-tray, blockdev-remove-medium, blockdev-insert-medium
> +# and blockdev-close-tray).
> +#
> +# @device: block device name
> +#
> +# @filename: filename of the new image to be loaded
> +#
> +# @format: #optional, format to open the new image with (defaults to
> +# the probed format)
> +#
> +# Since: 2.3
/me the temptation is strong to go back on my word in 26 - ...must resist...
:)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 25/38] block: Add blk_remove_bs(), (continued)
- [Qemu-devel] [PATCH v3 25/38] block: Add blk_remove_bs(), Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 28/38] blockdev: Add blockdev-remove-medium, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 29/38] blockdev: Add blockdev-insert-medium, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 27/38] blockdev: Add blockdev-close-tray, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 30/38] blockdev: Implement eject with basic operations, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 31/38] blockdev: Implement change with basic operations, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 32/38] block: Inquire tray state before tray-moved events, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 34/38] hmp: Use blockdev-change-medium for change command, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 33/38] qmp: Introduce blockdev-change-medium, Max Reitz, 2015/06/03
- Re: [Qemu-devel] [PATCH v3 33/38] qmp: Introduce blockdev-change-medium,
Eric Blake <=
- [Qemu-devel] [PATCH v3 35/38] blockdev: read-only-mode for blockdev-change-medium, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 37/38] iotests: More options for VM.add_drive(), Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 36/38] hmp: Add read-only-mode option to change command, Max Reitz, 2015/06/03
- [Qemu-devel] [PATCH v3 38/38] iotests: Add test for change-related QMP commands, Max Reitz, 2015/06/03