Re: [Qemu-devel] [PATCH v2 12/23] vl: run "late" notifiers immediately

[Paolo Bonzini]

On 04/06/2015 08:39, Peter Crosthwaite wrote:
> On Wed, Jun 3, 2015 at 10:08 AM, Paolo Bonzini <address@hidden> wrote:
>> If a machine_init_done notifier is added late, as part of a hot-plugged
>> device, run it immediately.
> 
> Blank line?

Yes, thanks.

Paolo

>> Signed-off-by: Paolo Bonzini <address@hidden>
> 
> Reviewed-by: Peter Crosthwaite <address@hidden>
> 
>> ---
>>  vl.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/vl.c b/vl.c
>> index 0707cfa..00def69 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -2498,14 +2498,20 @@ static void qemu_run_exit_notifiers(void)
>>      notifier_list_notify(&exit_notifiers, NULL);
>>  }
>>
>> +static bool machine_init_done;
>> +
>>  void qemu_add_machine_init_done_notifier(Notifier *notify)
>>  {
>>      notifier_list_add(&machine_init_done_notifiers, notify);
>> +    if (machine_init_done) {
>> +        notify->notify(notify, NULL);
>> +    }
>>  }
>>
>>  static void qemu_run_machine_init_done_notifiers(void)
>>  {
>>      notifier_list_notify(&machine_init_done_notifiers, NULL);
>> +    machine_init_done = true;
>>  }
>>
>>  static const QEMUOption *lookup_opt(int argc, char **argv,
>> --
>> 2.4.1
>>
>>
>>