Re: [Qemu-devel] [PATCH v1 4/5] tcg/optimize: fold constant test in tcg_opt_gen_mov

[Richard Henderson]

On 06/04/2015 02:44 PM, Aurelien Jarno wrote:
> On 2015-06-04 14:07, Richard Henderson wrote:
> > I think you should check for copies first, and only then do the TEMP_CONST
> > check.  That way we get to remove an op.
>
> If the state of a temp is TCG_TEMP_CONST, it can't be a copy as its
> state should be TCG_TEMP_COPY for that.

Ah, true.  I'd forgotten how that copy ring was represented.
The existing patch is fine, if you prefer.


r~