Re: [Qemu-devel] [Bug 1462131] [NEW] qemu mainline regression with xen-unstable: unable to start QMP

[Wen Congyang]

On 06/05/2015 06:09 AM, Don Slutz wrote:
> Public bug reported:
> 
> On 06/04/15 11:04, Fabio Fantoni wrote:
>> Today after trying xen-unstable build (tested many hours) of some days
>> ago I tried update qemu to latest development version (from git master
>> commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems that there is
>> a regression:
>>> xl create /etc/xen/W7.cfg
>>> Parsing config from /etc/xen/W7.cfg
>>> libxl: error: libxl_qmp.c:287:qmp_handle_error_response: received an
>>> error message from QMP server: QMP input object member 'id' is unexpected
>>> libxl: error: libxl_qmp.c:715:libxl__qmp_initialize: Failed to connect
>>> to QMP
>>
> 
> This is caused by:
> 
> commit 65207c59d99f2260c5f1d3b9c491146616a522aa
> Author: Markus Armbruster <address@hidden>
> Date:   Thu Mar 5 14:35:26 2015 +0100
> 
>     monitor: Drop broken, unused asynchronous command interface
> 
> 
>> DomU is working but operations that require QMP not (for example
>> save/restore).
>>
>> Thanks for any reply and sorry for my bad english.
> 
> ** Affects: qemu
>      Importance: Undecided
>          Status: New
> 
> ** Patch added: 
> "0001-monitor-Allow-Xen-s-broken-usage-of-asynchronous-com.patch"
>    
> https://bugs.launchpad.net/bugs/1462131/+attachment/4410103/+files/0001-monitor-Allow-Xen-s-broken-usage-of-asynchronous-com.patch
> 

Please try this patch:

>From 061dc4ed1012726fc0b8e1c6d0a784476f5c6d48 Mon Sep 17 00:00:00 2001
From: Wen Congyang <address@hidden>
Date: Fri, 5 Jun 2015 16:17:18 +0800
Subject: [PATCH] monitor: Allow the "id" key

The management application still needs the "id" key.

Signed-off-by: Wen Congyang <address@hidden>
---
 monitor.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/monitor.c b/monitor.c
index c7baa91..307dc53 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4955,6 +4955,8 @@ static QDict *qmp_check_input_obj(QObject *input_obj, 
Error **errp)
                           "arguments", "object");
                 return NULL;
             }
+        } else if (!strcmp(arg_name, "id")) {
+            /* FIXME: check duplicated IDs for async commands */
         } else {
             error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name);
             return NULL;
-- 
2.4.2