Re: [Qemu-devel] [PULL 4/4] qmp/hmp: add rocker device support

[Eric Blake]

On 06/05/2015 04:22 AM, Stefan Hajnoczi wrote:
> From: Scott Feldman <address@hidden>

> Add QMP/HMP support for rocker devices.  This is mostly for debugging purposes
> to see inside the device's tables and port configurations.  Some examples:
> 
> (qemu) info rocker sw1
> name: sw1
> id: 0x0000013512005452
> ports: 4
> 

> 
> [Changed "%-4ld" to "%4" PRIu64 in hmp_rocker_of_dpa_flows() since
> flow->hits is uint64_t.  This fixes compilation on 32-bit hosts.
> --Stefan]
> 
> Signed-off-by: Scott Feldman <address@hidden>
> Signed-off-by: Jiri Pirko <address@hidden>
> Message-id: address@hidden
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---

> +++ b/qapi/rocker.json
> @@ -0,0 +1,286 @@
> +##
> +# @Rocker:
> +#
> +# Rocker switch information.
> +#
> +# @name: switch name
> +#
> +# @id: switch ID
> +#
> +# @ports: number of front-panel ports
> +#
> +# Since: 2.4
> +##
> +{ 'struct': 'RockerSwitch',
> +  'data': { 'name': 'str', 'id': 'uint64', 'ports': 'uint32' } }
> +
> +##
> +# @rocker:

This...

> +#
> +# Return rocker switch information.
> +#
> +# Returns: @Rocker information
> +#
> +# Since: 2.4
> +##
> +{ 'command': 'query-rocker',

...and several other query- commands added in this file, are documented
incorrectly (missing the query- in the comment lead-in).  Since this is
already at a pull request, it's better to fix it up in a followup patch
if there is no other reason to hold up the pull.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature