qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation


From: Gal Hammer
Subject: Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device
Date: Mon, 08 Jun 2015 16:52:10 +0300
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 08/06/2015 16:43, Paolo Bonzini wrote:


On 08/06/2015 15:42, Gal Hammer wrote:
On 03/06/2015 19:37, Paolo Bonzini wrote:

Since Michael said he'd merge this version, there's just one thing I
would change.  You can access the region only one byte at a time, and
let the memory core fix endianness here:

I've applied the change offered below. Thanks.

There are two unanswered questions:

1. You wrote that I should not use the memory_region_init_io() function.
Should I use memory_region_init_ram() instead?

This is related to the uncached vs. cached memory discussion.  Michael
agreed that it's okay to do it this way.

OK. Nothing is changed for now.

2. Is it possible to create a sysbus device using the "-device" command
line argument? I vaguely recall that it is not possible to do it and
that's the reason that I specifically add the device in the pc init.

It's now possible, but it is somewhat complicated.  I think it's simpler
to initialize this unconditionally and hide it (via ACPI _STA) if the
vmgenid is all zeros.

I didn't understand. I need the device to be a sysbus device so it won't be found as an ISA or a PCI device by Windows. So I need to know what ever or not it is possible to create a sysbus device using "-device". In either way it won't be created if vmgenid is not given so no need to hide it using _STA.

    Gal.

Paolo





reply via email to

[Prev in Thread] Current Thread [Next in Thread]