Re: [Qemu-devel] [PATCH 10/31] vl: allow full-blown QemuOpts syntax for -global

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 19/05/2015 18:30, Markus Armbruster wrote:
>> Restrictions on driver and property names in the shorthand syntax
>> driver.property=value before the patch:
>> 
>> * Both are at most 63 characters long, no whitespace
>> 
>> * Driver name cannot contain '.'
>> 
>> * Property name cannot contain '='
>> 
>> After the patch, we additionally have:
>> 
>> * Driver name cannot contain '='.
>> 
>> Okay as long as no such driver name exists.  Have you checked?
>
> Good catch!  I now have.
>
> I've grepped for
>
> - \\..*\".*=.*\",
>
> - TYPE_.*\".*=.*\"
>
> with no hits.
>
>> Please spell out the new restriction in the commit message.
>
> Will do.

I'm afraid you didn't.

>>> @@ -186,6 +188,9 @@ qemu-system-i386 -global
>>> ide-drive.physical_block_size=4096 -drive file=file,if=
>>>  In particular, you can use this to set driver properties for
>>> devices which are
>>>  created automatically by the machine model. To create a device which is 
>>> not 
>>>  created automatically and set properties on it, use address@hidden
>>> +
>>> +The two syntaxes are equivalent.  The longer one works for drivers
>>> whose name
>>> +contains a dot.
>>>  ETEXI
>>>  
>>>  DEF("boot", HAS_ARG, QEMU_OPTION_boot,
>> 
>> I'd explain this as follows:
>> 
>>     -global @address@hidden@var{value} is shorthand for -global
>>     address@hidden,address@hidden,address@hidden  The
>>     longhand syntax works even when @var{driver} contains a dot.
>
> Will do.

I'm afraid you didn't.  I'll post a follow-up patch.