Re: [Qemu-devel] [PATCH 1/2] fw_cfg: add fw_cfg_modify_i16 (update) method

[Gerd Hoffmann]

On Mo, 2015-06-08 at 14:26 -0400, Gabriel L. Somlo wrote:
> On Mon, Jun 08, 2015 at 02:10:44PM -0400, Gabriel L. Somlo wrote:
> > Allow the ability to modify the value of an existing 16-bit integer
> > fw_cfg item.
> > 
> > Signed-off-by: Gabriel Somlo <address@hidden>
> > ---
> > 
> > Couple of thoughts:
> > 
> >    1. I'm thinking about pre-emptively creating _i16, _i32, and _i64
> >       versions, but right now (for fixing sparc and ppc) we only need
> >       the _i16 version. What to do ?
> 
> Presumably, I'll update the documentation to mention these update
> functions as well (one more reason to do all three versions rather
> than just _i16) :)

Should be easy to add this once they are actually needed.
Documentation update is fine, can go incremental though.

cheers,
  Gerd