Re: [Qemu-devel] virt-test broken by 'gtk: add opengl support, using egl' 97edf3bd5

[Dr. David Alan Gilbert]

* Dr. David Alan Gilbert (address@hidden) wrote:
> Hi,
>   I've just bisected a virt-test breakage down to:

This is fixed by the just posted 'gtk: don't exit early in case gtk init fails'

Dave

> 
> 97edf3bd5 'gtk: add opengl support, using egl'
> 
> I think the problem is that it's trying to start X up early
> on, even in the cases when qemu would just print some help and
> exit.  I'm running virt-test on a remote machine via ssh and
> don't have DISPLAY set.
> 
> Symptom
> -------
> Virt-test run of migrate.default.tcp is marked as 'SKIP'
> The debug logs show:
>    TestNAError: usb controller ich9-usb-uhci1 not available
> 
> Bisect:
> GOOD 2.3.0 fresh iconfigure
> GOOD 4d2d2d8
> GOOD a308817743be5cc051d3379477f54027deb0befb
> GOOD 922cc8823e484733021a7be5b0e876eba2218623
> GOOD 9441aa282bc3213ef0530cab86f318b877bac25c
> GOOD 7ced9e9f6da2257224591b91727cfeee4f3977fb
> BAD 97edf3bd5eab8952d475de66ede77307c12b8c48
> BAD 63c67b6d4462b6589b371d55e3740e9f0dba3281
> BAD 2a90c454a1b90ace56ed908cd064f2fd483d1231
> BAD 39b87c7
> BAD 13644819c5bf322ae4c2a415aca77d5dbde95fe8
> BAD 6fa6b312765f698dc81b
> 
> 97edf3bd5eab8952d475de66ede77307c12b8c48 is the first bad commit
> commit 97edf3bd5eab8952d475de66ede77307c12b8c48
> Author: Gerd Hoffmann <address@hidden>
> Date:   Tue Jan 20 12:43:28 2015 +0100
> 
>     gtk: add opengl support, using egl
> 
> 
> Virt-test at startup runs
> 
> qemu -device ?
> 
> to get a list of devices; on older versions that gives
> me the list and exit's with $?=0
> 
> on 973ef3 it does:
> address@hidden virt-test]# /root/try/bin/qemu-system-x86_64 -device '?'
> 
> (qemu-system-x86_64:5192): Gtk-WARNING **: cannot open display: 
> 
> 
> (Test environment is RHEL7.1ish)
> 
> Dave
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK