[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification |
Date: |
Thu, 11 Jun 2015 14:03:09 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jun 11, 2015 at 01:19:24PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 10.06.2015 16:24, Stefan Hajnoczi wrote:
> >On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> >>On 09.06.2015 20:03, Stefan Hajnoczi wrote:
> >>>On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy
> >>>wrote:
> >>>>@@ -166,6 +167,19 @@ the header extension data. Each entry look like this:
> >>>> terminated if it has full length)
> >>>>+== Dirty bitmaps ==
> >>>>+
> >>>>+Dirty bitmaps is an optional header extension. It provides a possibility
> >>>>of
> >>>>+storing dirty bitmaps in qcow2 image. The fields are:
> >>>>+
> >>>>+ 0 - 3: nb_dirty_bitmaps
> >>>>+ Number of dirty bitmaps contained in the image
> >>>Is there a maximum?
> >>hmm. any proposals for this?
> >65535 seems practical.
>
> So, you suggest to reduce this field width to 2b? And additional 2 bytes
> reserved field, to achieve 8b-alignment?
No, I would leave it 32-bit but impose a little (which can be increased
later if necessary). That's how nb_snapshots works too.
pgpXW6W8VCNUQ.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH 8/8] iotests: test internal persistent dirty bitmap, (continued)
- [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification, Vladimir Sementsov-Ogievskiy, 2015/06/08
- Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification, John Snow, 2015/06/09
- Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification, Stefan Hajnoczi, 2015/06/09
- Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification, Stefan Hajnoczi, 2015/06/10
- Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification, Vladimir Sementsov-Ogievskiy, 2015/06/11
- Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification, John Snow, 2015/06/11
- Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification, Stefan Hajnoczi, 2015/06/12
- Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification, John Snow, 2015/06/12
Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification, Kevin Wolf, 2015/06/10
[Qemu-devel] [PATCH 3/8] block: store persistent dirty bitmaps, Vladimir Sementsov-Ogievskiy, 2015/06/08
[Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps, Vladimir Sementsov-Ogievskiy, 2015/06/08