Re: [Qemu-devel] [PATCH v2 1/2] target-arm/kvm64: Add cortex-a53 cpu support

[Peter Maydell]

On 2 June 2015 at 02:10,  <address@hidden> wrote:
> From: Shannon Zhao <address@hidden>
>
> Since commit e353102(target-arm: cpu64: Add support for Cortex-A53) has
> added Cortex-A53 cpu support for target-arm, this patch just enables it
> for kvm-arm.
>
> Here adding XGENE_POTENZA just makes the enum continuous.
>
> Signed-off-by: Shannon Zhao <address@hidden>
> Signed-off-by: Shannon Zhao <address@hidden>
> ---

> --- a/target-arm/kvm64.c
> +++ b/target-arm/kvm64.c
> @@ -50,6 +50,8 @@ bool kvm_arm_get_host_cpu_features(ARMHostCPUClass *ahcc)
>          KVM_ARM_TARGET_AEM_V8,
>          KVM_ARM_TARGET_FOUNDATION_V8,
>          KVM_ARM_TARGET_CORTEX_A57,
> +        KVM_ARM_TARGET_XGENE_POTENZA,
> +        KVM_ARM_TARGET_CORTEX_A53,
>          QEMU_KVM_ARM_TARGET_NONE
>      };
>      struct kvm_vcpu_init init;

This is wrong -- this list should only include CPUs which were supported
in the very old kernels which don't know about PREFERRED_TARGET (see
the comment above the array).

Since the patchset looks OK otherwise, I'll just delete those two
lines and put it into target-arm.next.

thanks
-- PMM