Re: [Qemu-devel] [PATCH 08/16] qapi: Fix to reject stray 't', 'f' and 'n'

[Eric Blake]

On 06/12/2015 08:51 AM, Markus Armbruster wrote:
> Screwed up in commit e53188a.
> 

And partly my fault for taking a patch written in python by someone
else, without being a python guru myself.  :)

> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi.py | 26 ++++++++++++--------------
>  1 file changed, 12 insertions(+), 14 deletions(-)
> 

Is it worth a testsuite enhancement to expose this?

> +            elif self.src.startswith("true", self.pos):
> +                self.val = True
> +                self.cursor += 3
> +                return
> +            elif self.src.startswith("false", self.pos):

We still parse things like bare 'truest' as the token 'true'
concatenated with the nonsense 'st', which is probably not the nicest of
error messages, but the chances of someone mistyping bare words is not
worth making it more robust.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature