[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/11] vl: Avoid qerror_report() outside QMP com
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 02/11] vl: Avoid qerror_report() outside QMP command handlers |
|
Date: |
Sat, 13 Jun 2015 21:09:49 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/13/2015 08:20 AM, Markus Armbruster wrote:
> qerror_report() is a transitional interface to help with converting
> existing monitor commands to QMP. It should not be used elsewhere.
> Replace by error_report() in initial startup helpers parse_sandbox()
> and parse_add_fd().
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> vl.c | 23 +++++++++--------------
> 1 file changed, 9 insertions(+), 14 deletions(-)
>
> #else
> - qerror_report(ERROR_CLASS_GENERIC_ERROR,
> - "sandboxing request but seccomp is not compiled into
> this build");
> + error_report("sandboxing request but seccomp is not compiled "
> + "into this build");
Pre-existing, but s/request/requested/ would sound better while touching
this.
Either way,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature