[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/11] qerror: Clean up QERR_ macros to expand i
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 05/11] qerror: Clean up QERR_ macros to expand into a single string |
Date: |
Mon, 15 Jun 2015 16:12:26 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sat, Jun 13, 2015 at 04:20:52PM +0200, Markus Armbruster wrote:
> These macros expand into error class enumeration constant, comma,
> string. Unclean. Has been that way since commit 13f59ae.
>
> The error class is always ERROR_CLASS_GENERIC_ERROR since the previous
> commit.
>
> Clean up as follows:
>
> * Prepend every use of a QERR_ macro by ERROR_CLASS_GENERIC_ERROR, and
> delete it from the QERR_ macro. No change after preprocessing.
>
> * Rewrite error_set(ERROR_CLASS_GENERIC_ERROR, ...) into
> error_setg(...). Again, no change after preprocessing.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> backends/rng-egd.c | 8 ++---
> backends/rng-random.c | 6 ++--
> backends/rng.c | 2 +-
> backends/tpm.c | 2 +-
> balloon.c | 2 +-
> block.c | 2 +-
> block/backup.c | 4 +--
> block/commit.c | 2 +-
> block/mirror.c | 8 ++---
> block/qcow.c | 4 +--
> block/qcow2.c | 4 +--
> block/qed.c | 4 +--
> block/quorum.c | 4 +--
> block/snapshot.c | 4 +--
> block/stream.c | 4 +--
> block/vmdk.c | 12 ++++----
> blockdev-nbd.c | 2 +-
> blockdev.c | 43 +++++++++++++-------------
> blockjob.c | 8 ++---
> cpus.c | 8 ++---
> dump.c | 12 ++++----
> hmp.c | 10 +++---
> hw/core/nmi.c | 2 +-
> hw/core/qdev-properties-system.c | 3 +-
> hw/core/qdev-properties.c | 12 ++++----
> hw/core/qdev.c | 8 ++---
> hw/intc/openpic.c | 6 ++--
> hw/pci/pci-stub.c | 2 +-
> hw/ppc/spapr_pci.c | 8 ++---
> hw/s390x/s390-virtio.c | 2 +-
> hw/usb/redirect.c | 6 ++--
> include/qapi/qmp/qerror.h | 60 ++++++++++++++++++------------------
> migration/migration.c | 35 ++++++++++-----------
> migration/savevm.c | 2 +-
> monitor.c | 66
> ++++++++++++++++++++--------------------
> net/net.c | 12 ++++----
> qapi/opts-visitor.c | 24 +++++++--------
> qapi/qapi-visit-core.c | 28 ++++++++---------
> qapi/qmp-dispatch.c | 12 ++++----
> qapi/qmp-input-visitor.c | 28 ++++++++---------
> qapi/string-input-visitor.c | 24 +++++++--------
> qdev-monitor.c | 12 ++++----
> qemu-img.c | 2 +-
> qga/commands-posix.c | 40 ++++++++++++------------
> qga/commands-win32.c | 66
> ++++++++++++++++++++--------------------
> qga/main.c | 4 +--
> qmp.c | 34 ++++++++++-----------
> qom/object.c | 12 ++++----
> stubs/arch-query-cpu-def.c | 2 +-
> target-i386/cpu.c | 19 ++++++------
> tpm.c | 8 +++--
> ui/vnc.c | 4 +--
> util/qemu-option.c | 22 ++++++++------
> 53 files changed, 362 insertions(+), 358 deletions(-)
Nice simplification.
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpGjPzIRoben.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH 01/11] QemuOpts: Wean off qerror_report_err(), (continued)