[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 06/11] tpm: Avoid qerror_report() outside QMP com
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 06/11] tpm: Avoid qerror_report() outside QMP command handlers |
Date: |
Tue, 16 Jun 2015 16:21:42 +0200 |
qerror_report() is a transitional interface to help with converting
existing monitor commands to QMP. It should not be used elsewhere.
Replace by error_report().
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Luiz Capitulino <address@hidden>
---
tpm.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tpm.c b/tpm.c
index 8dadc67..c8889fa 100644
--- a/tpm.c
+++ b/tpm.c
@@ -140,22 +140,21 @@ static int configure_tpm(QemuOpts *opts)
id = qemu_opts_id(opts);
if (id == NULL) {
- qerror_report(ERROR_CLASS_GENERIC_ERROR, QERR_MISSING_PARAMETER, "id");
+ error_report(QERR_MISSING_PARAMETER, "id");
return 1;
}
value = qemu_opt_get(opts, "type");
if (!value) {
- qerror_report(ERROR_CLASS_GENERIC_ERROR, QERR_MISSING_PARAMETER,
- "type");
+ error_report(QERR_MISSING_PARAMETER, "type");
tpm_display_backend_drivers();
return 1;
}
be = tpm_get_backend_driver(value);
if (be == NULL) {
- qerror_report(ERROR_CLASS_GENERIC_ERROR, QERR_INVALID_PARAMETER_VALUE,
- "type", "a TPM backend type");
+ error_report(QERR_INVALID_PARAMETER_VALUE,
+ "type", "a TPM backend type");
tpm_display_backend_drivers();
return 1;
}
--
1.9.3
- [Qemu-devel] [PATCH v2 00/11] Sprint to the finish: purge QError, Markus Armbruster, 2015/06/16
- [Qemu-devel] [PATCH v2 06/11] tpm: Avoid qerror_report() outside QMP command handlers,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 03/11] vl: Use error_report() for --display errors, Markus Armbruster, 2015/06/16
- [Qemu-devel] [PATCH v2 01/11] QemuOpts: Wean off qerror_report_err(), Markus Armbruster, 2015/06/16
- [Qemu-devel] [PATCH v2 07/11] qmp: Wean off qerror_report(), Markus Armbruster, 2015/06/16
- [Qemu-devel] [PATCH v2 11/11] Include monitor/monitor.h exactly where needed, Markus Armbruster, 2015/06/16
- [Qemu-devel] [PATCH v2 08/11] qerror: Finally unused, clean up, Markus Armbruster, 2015/06/16
- [Qemu-devel] [PATCH v2 09/11] qerror: Move #include out of qerror.h, Markus Armbruster, 2015/06/16
- [Qemu-devel] [PATCH v2 02/11] vl: Avoid qerror_report() outside QMP command handlers, Markus Armbruster, 2015/06/16