Re: [Qemu-devel] [PATCH v2 08/23] pflash_cfi01: change to new-style MMIO accessors

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 09/06/2015 20:08, Richard Henderson wrote:
>> > > +    bool be = !!(pfl->features & (1 << PFLASH_BE));
>> > >
>> > > !!() not needed. Otherwise
>> > 
>> > I don't like magic bool-ification...
>> 
>> I don't like !! just as much.  If you don't like implicit conversion, then 
>> use
>> != 0.
>
> Fair enough, let's add to the coding still that we don't like !!.

$ git-grep '!!' | wc -l
369
$ git-grep -l '!!' | wc -l
170

Adding arbitrary rules to CODING_STYLE is one thing, adding rules that
are widely violated in existing code and not flagged by checkpatch.pl is
quite another.