Re: [Qemu-devel] [RFC v10 17/19] pcie_aer: expose pcie_aer_msg() interface

[Marcel Apfelbaum]

On 06/16/2015 11:11 AM, Chen Fan wrote:
> For vfio device, we need to propagate the aer error to
> Guest OS. we use the pcie_aer_msg() to send aer error
> to guest.
>
> Signed-off-by: Chen Fan <address@hidden>
> ---
>   hw/pci/pcie_aer.c         | 2 +-
>   include/hw/pci/pcie_aer.h | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c
> index 6171a29..373d1f2 100644
> --- a/hw/pci/pcie_aer.c
> +++ b/hw/pci/pcie_aer.c
> @@ -370,7 +370,7 @@ static void pcie_aer_msg_root_port(PCIDevice *dev, const 
> PCIEAERMsg *msg)
>    *
>    * Walk up the bus tree from the device, propagate the error message.
>    */
> -static void pcie_aer_msg(PCIDevice *dev, const PCIEAERMsg *msg)
> +void pcie_aer_msg(PCIDevice *dev, const PCIEAERMsg *msg)
>   {
>       uint8_t type;
>
> diff --git a/include/hw/pci/pcie_aer.h b/include/hw/pci/pcie_aer.h
> index 156acb0..c2ee4e2 100644
> --- a/include/hw/pci/pcie_aer.h
> +++ b/include/hw/pci/pcie_aer.h
> @@ -102,5 +102,6 @@ void pcie_aer_root_write_config(PCIDevice *dev,
>
>   /* error injection */
>   int pcie_aer_inject_error(PCIDevice *dev, const PCIEAERErr *err);
> +void pcie_aer_msg(PCIDevice *dev, const PCIEAERMsg *msg);
>
>   #endif /* QEMU_PCIE_AER_H */
Assuming the pcie_aer_msg will be used (after all reviews):

    Reviewed-by: Marcel Apfelbaum <address@hidden>

Thanks,
Marcel