Re: [Qemu-devel] [PATCH 09/13] target-mips: microMIPS32 R6 POOL32F instructions

[Leon Alrae]

On 12/06/2015 15:02, Yongbok Kim wrote:
> @@ -14155,13 +14243,88 @@ static void decode_micromips32_opc (CPUMIPSState 
> *env, DisasContext *ctx,
>                  break;
>              case 0x38:
>                  /* cmovs */
> -                switch ((ctx->opcode >> 6) & 0x3) {
> +                switch ((ctx->opcode >> 6) & 0x7) {
>                  case MOVN_FMT:
> +                    /* SELNEZ_FMT */
> +                    if (ctx->insn_flags & ISA_MIPS32R6) {
> +                        switch (ctx->opcode >> 9 & 0x3) {

Could you please add parentheses for consistency? (also in other patches in
this series)

Otherwise,

Reviewed-by: Leon Alrae <address@hidden>