[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/11] runstate: Add runstate store
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 01/11] runstate: Add runstate store |
Date: |
Wed, 17 Jun 2015 19:39:10 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Juan Quintela (address@hidden) wrote:
> This allows us to store the current state to send it through migration.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> include/sysemu/sysemu.h | 1 +
> vl.c | 12 ++++++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index 0304aa7..d7bec42 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -28,6 +28,7 @@ bool runstate_check(RunState state);
> void runstate_set(RunState new_state);
> int runstate_is_running(void);
> bool runstate_needs_reset(void);
> +bool runstate_store(char *str, size_t size);
> typedef struct vm_change_state_entry VMChangeStateEntry;
> typedef void VMChangeStateHandler(void *opaque, int running, RunState state);
>
> diff --git a/vl.c b/vl.c
> index 2201e27..c659a00 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -630,6 +630,18 @@ bool runstate_check(RunState state)
> return current_run_state == state;
> }
>
> +bool runstate_store(char *str, size_t size)
> +{
> + const char *state = RunState_lookup[current_run_state];
> + size_t len = strlen(state) + 1;
> +
> + if (len > size) {
> + return false;
> + }
> + memcpy(str, state, len);
> + return true;
> +}
> +
It seems a lot of work for a status string; but OK.
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> static void runstate_init(void)
> {
> const RunStateTransition *p;
> --
> 2.4.3
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 00/11] Migraiton events + optional sections, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 02/11] runstate: migration allows more transitions now, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 01/11] runstate: Add runstate store, Juan Quintela, 2015/06/16
- Re: [Qemu-devel] [PATCH 01/11] runstate: Add runstate store,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 03/11] migration: create new section to store global state, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 05/11] vmstate: Create optional sections, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 04/11] global_state: Make section optional, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 06/11] migration: Add configuration section, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 09/11] migration: No need to call trace_migrate_set_state(), Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 08/11] migration: Use always helper to set state, Juan Quintela, 2015/06/16