[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/11] migration: create migration event
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 10/11] migration: create migration event |
Date: |
Wed, 17 Jun 2015 13:45:16 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/16/2015 07:50 PM, Juan Quintela wrote:
> We have one argument that tells us what event has happened.
>
> Signed-off-by: Juan Quintela <address@hidden>
>
> X3
>
> Signed-off-by: Juan Quintela <address@hidden>
Intentional double-S-o-b?
> ---
> docs/qmp/qmp-events.txt | 14 ++++++++++++++
> migration/migration.c | 2 ++
> qapi/event.json | 14 ++++++++++++++
> 3 files changed, 30 insertions(+)
>
> +Data: None.
> +
> + - "status": migration status
> + See MigrationStatus in ~/qapi-scheme.json for possible values
s/scheme/schema/
> +++ b/qapi/event.json
> @@ -243,6 +243,20 @@
> { 'event': 'SPICE_MIGRATE_COMPLETED' }
>
> ##
> +# @MIGRATION
> +#
> +# Emitted when a migration event happens
> +#
> +# @status: @MigrationStatus describing the current migration status.
> +# If this field is not returned, no migration process
> +# has been initiated
Drop this second sentence. 'status' is emitted unconditionally (it is
not marked optional).
With those two changes,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 04/11] global_state: Make section optional, (continued)
- [Qemu-devel] [PATCH 06/11] migration: Add configuration section, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 09/11] migration: No need to call trace_migrate_set_state(), Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 08/11] migration: Use always helper to set state, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 07/11] migration: Use cmpxchg correctly, Juan Quintela, 2015/06/16
- [Qemu-devel] [PATCH 10/11] migration: create migration event, Juan Quintela, 2015/06/16
- Re: [Qemu-devel] [PATCH 10/11] migration: create migration event,
Eric Blake <=
- [Qemu-devel] [PATCH 11/11] migration: Add migration events on target side, Juan Quintela, 2015/06/16