[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage"
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage" |
|
Date: |
Thu, 18 Jun 2015 15:47:42 +0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 |
27.05.2015 20:53, Markus Armbruster wrote:
> Since we now require GLib 2.22+ (commit f40685c), we don't have to
> work around lack of g_strcmp0() anymore.
> qga/main.c | 2 +-
> - if (domain && strcmp(domain, "syslog") == 0) {
> + if (g_strcmp0(domain, "syslog") == 0) {
Why bother? To me the current version is easier to read,
it is traditional and working, while for g_strcmp0() I
have to look up documentation.
/mjt