|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH v6 3/7] hw/pci-bridge: introduce "hotplug" property |
| Date: | Thu, 18 Jun 2015 15:47:41 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 17/06/2015 16:02, Michael S. Tsirkin wrote: > > Are you okay with the flag's name, PCI_BRIDGE_DEV_F_HOTPLUG? If not, > > what would be your preference? > > PCI_BRIDGE_DEV_F_SHPC_REQ Do not abbrev unless necessary. :) What about PCI_BRIDGE_DEV_F_HAS_SHPC or even just PCI_BRIDGE_DEV_F_SHPC? Paolo > Also add macro for "shpc" property string to avoid duplication. > Also clear msi explicitly - no need for that to depend on shpc. >
| [Prev in Thread] | Current Thread | [Next in Thread] |