Re: [Qemu-devel] [PATCH 00/10 v12] tilegx: Firstly add tilegx target for linux-user

[Peter Maydell]

On 13 June 2015 at 14:07, Chen Gang <address@hidden> wrote:
> It can finish running "Hello world" elf64 binary, and the related test
> cases:
>
>   - with "--enable-debug", enable assertion with "-g":
>
>     ./tilegx-linux-user/qemu-tilegx -L /upstream/release-tile 
> /upstream/release-tile/test/test_shared
>     ./tilegx-linux-user/qemu-tilegx -d all -L /upstream/release-tile 
> /upstream/release-tile/test/test_shared > /tmp/a.log
>
>     ./tilegx-linux-user/qemu-tilegx /upstream/release-tile/test/test_static
>     ./tilegx-linux-user/qemu-tilegx -d all 
> /upstream/release-tile/test/test_static  > /tmp/b.log
>
>   - without "--enable-debug", disable assertion with "-O2 -g":
>
>     ./tilegx-linux-user/qemu-tilegx -L /upstream/release-tile 
> /upstream/release-tile/test/test_shared
>     ./tilegx-linux-user/qemu-tilegx -d all -L /upstream/release-tile 
> /upstream/release-tile/test/test_shared > /tmp/c.log
>
>     ./tilegx-linux-user/qemu-tilegx /upstream/release-tile/test/test_static
>     ./tilegx-linux-user/qemu-tilegx -d all 
> /upstream/release-tile/test/test_static  > /tmp/d.log
>
> Chen Gang (10):
>   linux-user: tilegx: Firstly add architecture related features
>   linux-user: Support tilegx architecture in linux-user
>   linux-user/syscall.c: conditionalize syscalls which are not defined in
>     tilegx
>   target-tilegx: Add opcode basic implementation from Tilera Corporation
>   target-tilegx/opcode_tilegx.h: Modify it to fit QEMU usage
>   target-tilegx: Add special register information from Tilera
>     Corporation
>   target-tilegx: Add cpu basic features for linux-user
>   target-tilegx: Add several helpers for instructions translation
>   target-tilegx: Generate tcg instructions to finish "Hello world"
>   target-tilegx: Add TILE-Gx building files

I gave some of these my reviewed-by: tag in v11. Please don't
just drop that, it wastes my time when I end up re-looking
at patches I've already reviewed.

Anyway, you can add my Reviewed-by: tag to patches 1-7 and 10.
I'll let rth do patches 8 and 9.

Opinions on whether we should put this series into master now
(assuming 8 and 9 are good), or delay until after 2.4 release?

thanks
-- PMM