Re: [Qemu-devel] [Qemu-block] [PATCH 2/9] iohandler: Use aio code

[Fam Zheng]

On Tue, 06/16 14:57, Stefan Hajnoczi wrote:
> On Wed, Jun 10, 2015 at 04:59:44PM +0800, Fam Zheng wrote:
> > diff --git a/iohandler.c b/iohandler.c
> > index 826f713..f5d7704 100644
> > --- a/iohandler.c
> > +++ b/iohandler.c
> > @@ -32,111 +32,39 @@
> >  #include <sys/wait.h>
> >  #endif
> >  
> > -typedef struct IOHandlerRecord {
> > -    IOHandler *fd_read;
> > -    IOHandler *fd_write;
> > -    void *opaque;
> > -    QLIST_ENTRY(IOHandlerRecord) next;
> > -    int fd;
> > -    int pollfds_idx;
> > -    bool deleted;
> > -} IOHandlerRecord;
> > +static AioContext *iohandler_ctx;
> 
> Please include a comment explaining why this AioContext is needed in
> addition to the global qemu_aio_context.

OK!

It's needed because iohandlers shouldn't be polled by aio_poll().

Fam