Re: [Qemu-devel] [PATCH 1/2] kvm/x86: Hyper-V based guest crash data handling

[Paolo Bonzini]

On 19/06/2015 12:28, Andrey Smetanin wrote:
> On Wed, 2015-06-17 at 14:44 +0200, Paolo Bonzini wrote:
>>
>> On 11/06/2015 15:18, Denis V. Lunev wrote:
>>> From: Andrey Smetanin <address@hidden>
>>>
>>> Windows 2012 guests can notify hypervisor about occurred guest crash
>>> (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does
>>> handling of this MSR's by KVM and sending notification to user space that
>>> allows to gather Windows guest crash dump by QEMU/LIBVIRT.
>>>
>>> The idea is to provide functionality equal to pvpanic device without
>>> QEMU guest agent for Windows.
>>>
>>> The idea is borrowed from Linux HyperV bus driver and validated against
>>> Windows 2k12.
>>>
>>> Signed-off-by: Andrey Smetanin <address@hidden>
>>> Signed-off-by: Denis V. Lunev <address@hidden>
>>> CC: Gleb Natapov <address@hidden>
>>> CC: Paolo Bonzini <address@hidden>
>>> ---
>>>  arch/x86/include/uapi/asm/hyperv.h | 10 +++++
>>>  arch/x86/kvm/Makefile              |  2 +-
>>>  arch/x86/kvm/mshv.c                | 84 
>>> ++++++++++++++++++++++++++++++++++++++
>>>  arch/x86/kvm/mshv.h                | 32 +++++++++++++++
>>
>> Please use hyperv.[ch] or hyper-v.[ch] and name the functions kvm_hv_*.
>>  We can later move more functions from x86.c to the new file, so it's
>> better to keep the names consistent.
>>
> Should we prepare a 1st patch in this series where
> we move all hyper-v related code from x86.c into hyperv.c new file with
> copyright extension ?

If you want to do that, I certainly wouldn't complain.

Paolo