Re: [Qemu-devel] [PATCH v2 1/7] qdev: Deprecated qdev_init() is finally unused, drop

[Markus Armbruster]

Andreas Färber <address@hidden> writes:

> Hi Markus,
>
> Could you please add a verbose rationale here like "qdev_init() does not
> propagate the Error* and should be replaced by ..."?

What about:

    qdev_init() is a wrapper around setting property "realized" to true
    plus error handling, which passes errors to qerror_report_err().
    qerror_report_err() is a transitional interface to help with
    converting existing monitor commands to QMP.  It should not be used
    elsewhere.

    All code has been modernized to avoid qdev_init() and its
    inappropriate error handling.  We can finally drop it.

> Am 13.06.2015 um 13:18 schrieb Markus Armbruster:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> ---
>>  hw/core/qdev.c         | 47 ++++++++++++++++-------------------------------
>>  include/hw/qdev-core.h |  3 +--
>>  2 files changed, 17 insertions(+), 33 deletions(-)
>
> Otherwise,
>
> Reviewed-by: Andreas Färber <address@hidden>

Thanks!