[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 8/8] qom: don't pass string table to object_g
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v5 8/8] qom: don't pass string table to object_get_enum method |
Date: |
Fri, 19 Jun 2015 17:15:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
Am 27.05.2015 um 17:07 schrieb Daniel P. Berrange:
> Now that properties can be explicitly registered as an enum
> type, there is no need to pass the string table to the
> object_get_enum method. The object property registration
> already has a pointer to the string table.
>
> In changing this method signature, the hostmem backend object
> has to be converted to use the new enum property registration
> code, which simplifies it somewhat.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> backends/hostmem.c | 22 ++++++++--------------
> include/qom/object.h | 4 ++--
> numa.c | 2 +-
> qom/object.c | 19 +++++++++++++++++--
> tests/check-qom-proplist.c | 43 +++++++++++++++++++++++++++++++++++++++++++
> 5 files changed, 71 insertions(+), 19 deletions(-)
There's been no protest after it appeared in v4, so I'm applying it for
my v3 pull. If anyone has objections, please speak up now.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
- Re: [Qemu-devel] [PATCH v5 8/8] qom: don't pass string table to object_get_enum method,
Andreas Färber <=