qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 6/8] qom: make enum string tables const-corre


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v5 6/8] qom: make enum string tables const-correct
Date: Fri, 19 Jun 2015 10:05:34 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 05/27/2015 09:07 AM, Daniel P. Berrange wrote:
> The enum string table parameters in various QOM/QAPI methods
> are declared 'const char *strings[]'. This results in const
> warnings if passed a variable that was declared as
> 
>    static const char * const strings[] = { .... };

Not sure if the style would be '*const' instead of '* const' everywhere,
but if checkpatch.pl didn't complain, it's not worth a respin.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]