[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vl: move rom_load_all after machine init done
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] vl: move rom_load_all after machine init done |
|
Date: |
Mon, 22 Jun 2015 11:53:24 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 22/06/2015 11:49, Eric Auger wrote:
>> > It seems safe because rom_load_all really doesn't load anything, it only
>> > does an overlap check. Is this right?
> it does the check + isrom field setting
>> >
>> > Is the bug that some overlapping ROMs are not detected? The commit
>> > message is not clear.
> The regression is that the both overlap check and isrom setting are not
> done since ROM are inserted in the roms list afterwards, at machine init
> done time. The bug was not really observed yet I think.
isrom is just an optimization though, right? What is it useful for?
Paolo