Re: [Qemu-devel] [PATCH] net: Allow specifying maximum number of network NICs during configure

[Stefan Hajnoczi]

On Sat, Jun 20, 2015 at 02:26:29PM +0300, Shmulik Ladkani wrote:
> Currently, MAX_NICS is hardcoded as 8.
> 
> Add a configuration option '--net-max-nics' so one can override the
> default.
> Unless specified, default value is kept as 8.
> 
> Signed-off-by: Shmulik Ladkani <address@hidden>
> ---
>  configure         | 7 +++++++
>  include/net/net.h | 2 +-
>  2 files changed, 8 insertions(+), 1 deletion(-)

The -device e1000,netdev=tap0,id=e1000-nic0 syntax is preferred to -net
nic syntax and does not have the 8 NIC limit.

Please use the -device syntax instead of -net.  Emulated NICs that
support virtio_net_hdr offload also perform better with the -device
syntax because -net nic does not allow virtio_net_hdr offloads.

If you think this patch should be merged, please explain the use case.

pgpNvBwe2b7Q1.pgp
Description: PGP signature