[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v4 5/5] raw-posix: Introduce hdev_i
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v4 5/5] raw-posix: Introduce hdev_is_sg() |
|
Date: |
Mon, 22 Jun 2015 13:33:06 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jun 22, 2015 at 01:18:43PM +0300, Dimitris Aragiorgis wrote:
> So I suggest we go with the submitted patch taking into account Eric's
> proposal: The code first stat()s the given filename to ensure it is a
> character device node, and then it issues the SG_GET_VERSION_NUM and
> SG_GET_SCSI_ID ioctl()s.
That's fine.
Regarding Eric's comment about ioctl number collisions, I've checked
Linux Documentation/ioctl/ioctl-number.txt. At least under Linux there
is no collision for SG_GET_VERSION_NUM/SG_GET_SCSI_ID.
Stefan
pgpioSBT_g9JW.pgp
Description: PGP signature