[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/5] xen/pass-through: constify some static data
From: |
Stefano Stabellini |
Subject: |
[Qemu-devel] [PULL 4/5] xen/pass-through: constify some static data |
Date: |
Mon, 22 Jun 2015 14:09:10 +0100 |
From: Jan Beulich <address@hidden>
This is done indirectly by adjusting two typedefs and helps emphasizing
that the respective tables aren't supposed to be modified at runtime
(as they may be shared between devices).
Signed-off-by: Jan Beulich <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>
---
hw/xen/xen_pt.h | 8 ++++----
hw/xen/xen_pt_config_init.c | 3 +--
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h
index 4bba559..232165a 100644
--- a/hw/xen/xen_pt.h
+++ b/hw/xen/xen_pt.h
@@ -31,7 +31,7 @@ void xen_pt_log(const PCIDevice *d, const char *f, ...)
GCC_FMT_ATTR(2, 3);
/* Helper */
#define XEN_PFN(x) ((x) >> XC_PAGE_SHIFT)
-typedef struct XenPTRegInfo XenPTRegInfo;
+typedef const struct XenPTRegInfo XenPTRegInfo;
typedef struct XenPTReg XenPTReg;
typedef struct XenPCIPassthroughState XenPCIPassthroughState;
@@ -133,11 +133,11 @@ struct XenPTReg {
uint32_t data; /* emulated value */
};
-typedef struct XenPTRegGroupInfo XenPTRegGroupInfo;
+typedef const struct XenPTRegGroupInfo XenPTRegGroupInfo;
/* emul reg group size initialize method */
typedef int (*xen_pt_reg_size_init_fn)
- (XenPCIPassthroughState *, const XenPTRegGroupInfo *,
+ (XenPCIPassthroughState *, XenPTRegGroupInfo *,
uint32_t base_offset, uint8_t *size);
/* emulated register group information */
@@ -152,7 +152,7 @@ struct XenPTRegGroupInfo {
/* emul register group management table */
typedef struct XenPTRegGroup {
QLIST_ENTRY(XenPTRegGroup) entries;
- const XenPTRegGroupInfo *reg_grp;
+ XenPTRegGroupInfo *reg_grp;
uint32_t base_offset;
uint8_t size;
QLIST_HEAD(, XenPTReg) reg_tbl_list;
diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
index f373092..dd37be3 100644
--- a/hw/xen/xen_pt_config_init.c
+++ b/hw/xen/xen_pt_config_init.c
@@ -96,8 +96,7 @@ XenPTReg *xen_pt_find_reg(XenPTRegGroup *reg_grp, uint32_t
address)
}
static uint32_t get_throughable_mask(const XenPCIPassthroughState *s,
- const XenPTRegInfo *reg,
- uint32_t valid_mask)
+ XenPTRegInfo *reg, uint32_t valid_mask)
{
uint32_t throughable_mask = ~(reg->emu_mask | reg->ro_mask);
--
1.7.10.4
- [Qemu-devel] [PULL 0/5] xen-220615, Stefano Stabellini, 2015/06/22
- [Qemu-devel] [PULL 5/5] Revert "xen-hvm: increase maxmem before calling xc_domain_populate_physmap", Stefano Stabellini, 2015/06/22
- [Qemu-devel] [PULL 4/5] xen/pass-through: constify some static data,
Stefano Stabellini <=
- [Qemu-devel] [PULL 2/5] xen/pass-through: ROM BAR handling adjustments, Stefano Stabellini, 2015/06/22
- [Qemu-devel] [PULL 3/5] xen/pass-through: log errno values rather than function return ones, Stefano Stabellini, 2015/06/22
- [Qemu-devel] [PULL 1/5] xen/pass-through: fold host PCI command register writes, Stefano Stabellini, 2015/06/22
- Re: [Qemu-devel] [PULL 0/5] xen-220615, Peter Maydell, 2015/06/23