[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] qga: Clean up unnecessarily dirty casts
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] qga: Clean up unnecessarily dirty casts |
Date: |
Mon, 22 Jun 2015 16:01:07 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/22/2015 01:26 PM, Markus Armbruster wrote:
> qga_vss_fsfreeze() casts error_set_win32() from
>
> void (*)(Error **, int, ErrorClass, const char *, ...)
>
> to
>
> void (*)(void **, int, int, const char *, ...)
>
> The result is later called. Since the two types are not compatible,
> the call is undefined behavior. It works in practice anyway.
Better than some other horrid casts we do, like monitor.c playing fast
and loose with 'Monitor *' vs. 'FILE *' in hmp_info_mtree() and friends.
But that's a cleanup for another series.
>
> However, there's no real need for trickery here. Clean it up as
> follows:
>
> * Declare struct Error, and fix the first parameter.
>
> * Switch to error_setg_win32(). This gets rid of the troublesome
> ErrorClass parameter. Requires converting error_setg_win32() from
> macro to function, but that's trivially easy, because this is the
> only user of error_set_win32().
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 1/7] error: De-duplicate code creating Error objects, (continued)
- [Qemu-devel] [PATCH 1/7] error: De-duplicate code creating Error objects, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PATCH 5/7] error: error_set_errno() is unused, drop, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PATCH 4/7] qga/vss-win32: Document the DLL requires non-null errp, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PATCH 2/7] error: Make error_setg() a function, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PATCH 6/7] error: Revamp interface documentation, Markus Armbruster, 2015/06/22
- [Qemu-devel] [PATCH 3/7] qga: Clean up unnecessarily dirty casts, Markus Armbruster, 2015/06/22
- Re: [Qemu-devel] [PATCH 3/7] qga: Clean up unnecessarily dirty casts,
Eric Blake <=
- [Qemu-devel] [PATCH 7/7] error: On abort, report where the error was created, Markus Armbruster, 2015/06/22