[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v crash occured |
|
Date: |
Tue, 23 Jun 2015 11:53:14 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 22/06/2015 19:46, Andreas Färber wrote:
>>>>> >>>> On the other hand, I wonder if current_cpu is available in
>>>>> >>>> qemu_system_guest_panicked. If so, you could add the field to the
>>>>> >>>> generic CPUState struct and migrate it as a subsection of
>>>>> >>>> vmstate_cpu_common.
>>> >> Hm, not sure whether it is.
>> >
>> > It should be...
> Obviously depends on the call site. :) At some point in cpu-exec.c,
> current_cpu gets set to NULL. So the function would at least deserve a
> comment on when (not to) use it.
I think it could be used anyway even if current_cpu. The difference
would be whether the crash is attached to a CPU or not.
Paolo
- Re: [Qemu-devel] [PATCH 07/11] kvm/x86: added hyper-v crash data and ctl msr's get/set'ers, (continued)
[Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v crash occured, Denis V. Lunev, 2015/06/22
- Re: [Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v crash occured, Andreas Färber, 2015/06/22
- Re: [Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v crash occured, Paolo Bonzini, 2015/06/22
- Re: [Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v crash occured, Andreas Färber, 2015/06/22
- Re: [Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v crash occured, Denis V. Lunev, 2015/06/22
- Re: [Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v crash occured, Paolo Bonzini, 2015/06/22
- Re: [Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v crash occured, Andreas Färber, 2015/06/22
- Re: [Qemu-devel] [PATCH 11/11] qemu/kvm: mark in cpu state that hyper-v crash occured,
Paolo Bonzini <=
[Qemu-devel] [PATCH 04/11] kvm/x86: added hyper-v crash msrs into kvm hyperv context, Denis V. Lunev, 2015/06/22
[Qemu-devel] [PATCH 08/11] kvm/x86: add sending hyper-v crash notification to user space, Denis V. Lunev, 2015/06/22
[Qemu-devel] [PATCH 02/11] kvm: introduce vcpu_debug = kvm_debug + vcpu context, Denis V. Lunev, 2015/06/22
[Qemu-devel] [PATCH 01/11] kvm/x86: move Hyper-V MSR's/hypercall code into hyperv.c file, Denis V. Lunev, 2015/06/22
[Qemu-devel] [PATCH 10/11] qemu/kvm: kvm hyper-v based guest crash event handling, Denis V. Lunev, 2015/06/22
[Qemu-devel] [PATCH 09/11] kvm/x86: distingiush hyper-v guest crash notification, Denis V. Lunev, 2015/06/22