qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] thread-win32: fix GetThreadContext() permanentl


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] thread-win32: fix GetThreadContext() permanently fails
Date: Tue, 23 Jun 2015 13:32:19 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0


On 23/06/2015 13:18, Daniel P. Berrange wrote:
> > For 2.5, however, I wonder if SuspendThread/ResumeThread is needed at
> > all now that cpu_exit doesn't have to undo block chaining anymore.  Even
> > on POSIX platforms the signal might not be necessary anymore.
> 
> If you don't have that signal / SuspendThread/ResumtThread requirement,

That was independent of QEMU reinventing the wheel for mutexes/condvars.

> might that enable QEMU to just depend on the winpthreads library that
> is provided by Mingw project, and not bother reinventing the wheel for
> thread library portabilty ?

We can and should just reuse glib these days as much as we can (probably
not entirely because glib doesn't have detached threads).  At least a
few years ago, winpthreads was much slower than native Win32, which is
why everyone reinvents the wheel.

I was planning to do it in 2.5.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]