Re: [Qemu-devel] [PULL 0/5] xen-220615

[Stefano Stabellini]

On Tue, 23 Jun 2015, Peter Maydell wrote:
> On 23 June 2015 at 11:30, Stefano Stabellini
> <address@hidden> wrote:
> > On Tue, 23 Jun 2015, Peter Maydell wrote:
> >> I'm afraid I can't apply this -- this revert commit is missing a 
> >> signed-off-by
> >> line. Can you respin, please?
> >
> > I thought that being a straight revert, didn't need a SOB line.
> > xen-220615-2 is the tag with SOB line on the last commit:
> >
> > git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-220615-2
> 
> "xen/pass-through: fold host PCI command register writes"
> only has Jan's signoff, not yours too... (apologies for not
> noticing that first time around.)
> 
> I have a bit in my pull-request-creation script that automatically
> checks that every commit has my signoff, to avoid this kind of
> mistake:
> https://git.linaro.org/people/peter.maydell/misc-scripts.git/blob/HEAD:/make-pullreq#l98

Sorry. I noticed that this is the second time that I make this mistake.
Part of the problem is that in other communities (Linux, Xen Project),
maintainers are not required to add their SOB if they don't modify the
patch.

Here is my third try:

git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-220615-3