Re: [Qemu-devel] [RFC v2 07/34] exec-all: Move cpu_can_do_io to qom/cpu.h

[Pavel Dovgaluk]

> From: Paolo Bonzini [mailto:address@hidden
> On 24/06/2015 13:40, Pavel Dovgaluk wrote:
> >>> > > +    /* If not executing code then assume we are ok.  */
> >>> > > +    if (cpu->current_tb == NULL) {
> >>> > > +        return true;
> >>> > > +    }
> >>> > > +    return cpu->can_do_io != 0;
> >> >
> >> > For what it's worth, I think the "if" here is dead.  Pavel?
> > cpu_can_do_io can be called from cpus.c and translate-all.c
> > In both cases these calls could be made outside the generated code.
> 
> Yes, but doesn't your commit 626cf8f (icount: set can_do_io outside TB
> execution, 2014-12-08) cause cpu->can_do_io == 0 to imply
> cpu->current_tb != NULL?

I see. You are right, as far I can understand the control flow.

Pavel Dovgalyuk