Re: [Qemu-devel] [PATCH v3 3/5] target-mips: remove identical code in different branch

[Leon Alrae]

On 24/06/2015 15:37, Aurelien Jarno wrote:
> On 2015-06-19 11:08, Leon Alrae wrote:
>> Signed-off-by: Leon Alrae <address@hidden>
>> ---
>>  target-mips/translate.c | 25 ++++---------------------
>>  1 file changed, 4 insertions(+), 21 deletions(-)
>>
>> diff --git a/target-mips/translate.c b/target-mips/translate.c
>> index 1d128ee..6fd6dd9 100644
>> --- a/target-mips/translate.c
>> +++ b/target-mips/translate.c
>> @@ -11852,11 +11852,7 @@ static int decode_mips16_opc (CPUMIPSState *env, 
>> DisasContext *ctx)
>>               *      when in debug mode...
>>               */
>>              check_insn(ctx, ISA_MIPS32);
>> -            if (!(ctx->hflags & MIPS_HFLAG_DM)) {
>> -                generate_exception(ctx, EXCP_DBp);
>> -            } else {
>> -                generate_exception(ctx, EXCP_DBp);
>> -            }
>> +            generate_exception(ctx, EXCP_DBp);
> 
> The reason for this duplicated code, is from the comment above, that is
> we are not sure which exception should be generated in debug mode. If
> someone knows the answer (or my experiment that on real hardware) that 
> might be a good opportu to fix that the correct way.

Yes, that's why I left the comment so we are still aware of this problem and
we know where to fix it once we know the answer. But at the time I was
touching this code I felt it should be removed (it generates 4 medium issues
in Coverity).

Leon