Re: [Qemu-devel] [PATCH v2 for-2.4 3/3] hw/arm/virt: Make block devices default to virtio

[Markus Armbruster]

Peter Maydell <address@hidden> writes:

> On 25 June 2015 at 08:40, Markus Armbruster <address@hidden> wrote:
>> Peter Maydell <address@hidden> writes:
>>
>>> Now we have virtio-pci, we can make the virt board's default block
>>> device type be IF_VIRTIO. This allows users to use simplified
>>> command lines that don't have to explicitly create virtio-pci-blk
>>> devices; the -hda &c very short options now also work.
>>>
>>> This means we also need to set no_cdrom to avoid getting a
>>> default cdrom device -- this is needed because the virtio-blk
>>> device will fail if it is connected to a block backend with
>>> no media, which is what the default cdrom device typically is.
>>> Providing a cdrom with media via -cdrom will still work.
>>
>> It'll create a virtio-blk device with non-removable medium, won't it?
>
> Yes, I think so. Mostly I cared that -cdrom won't make qemu die with a
> confusing error.
>
> (Without no_cdrom, qemu dies even if you don't say -cdrom, because
> of the default empty drive.)

Instead of "will still work", I'd like to see something like "will
succeed, but silently create a device with non-removable medium, which
is probably not what you want, but the best we can do now".

>>> The command line will be changed to include 'if=none', as the
>>
>> will have to be changed
>
> Yes.
>
> -- PMM