Re: [Qemu-devel] [PULL 06/11] icount: Add QemuOpts for icount

[Peter Maydell]

On 6 August 2014 at 17:12, Paolo Bonzini <address@hidden> wrote:
> From: Sebastian Tanase <address@hidden>
>
> Make icount parameter use QemuOpts style options in order
> to easily add other suboptions.
>
> Signed-off-by: Sebastian Tanase <address@hidden>
> Tested-by: Camille Bégué <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

Hi. I've just noticed that this change means we will
abort and dump core for user command line errors with icount:

$ qemu-system-x86_64 -icount bang
qemu-system-x86_64: icount: Invalid shift value
Aborted (core dumped)

> +        configure_icount(icount_opts, &error_abort);

...we shouldn't be using error_abort for situations where
the errors could be caused by user input, only where we know
that any error must be a bug in QEMU itself.

thanks
-- PMM