Re: [Qemu-devel] [PATCH 10/11] migration: create migration event

[Juan Quintela]

Eric Blake <address@hidden> wrote:
> On 06/16/2015 07:50 PM, Juan Quintela wrote:
>> We have one argument that tells us what event has happened.
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>> 
>> X3
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>
> Intentional double-S-o-b?

No, merge artifact


>
>> ---
>>  docs/qmp/qmp-events.txt | 14 ++++++++++++++
>>  migration/migration.c   |  2 ++
>>  qapi/event.json         | 14 ++++++++++++++
>>  3 files changed, 30 insertions(+)
>> 
>
>> +Data: None.
>> +
>> + - "status": migration status
>> +     See MigrationStatus in ~/qapi-scheme.json for possible values
>
> s/scheme/schema/

fixed

>
>
>> +++ b/qapi/event.json
>> @@ -243,6 +243,20 @@
>>  { 'event': 'SPICE_MIGRATE_COMPLETED' }
>> 
>>  ##
>> +# @MIGRATION
>> +#
>> +# Emitted when a migration event happens
>> +#
>> +# @status: @MigrationStatus describing the current migration status.
>> +#          If this field is not returned, no migration process
>> +#          has been initiated
>
> Drop this second sentence. 'status' is emitted unconditionally (it is
> not marked optional).
>
> With those two changes,
> Reviewed-by: Eric Blake <address@hidden>

fixed