Re: [Qemu-devel] [PATCH v4 1/5] softmmu: add helper function to pass through retaddr

[Aurelien Jarno]

On 2015-06-29 10:23, Pavel Dovgalyuk wrote:
> This patch introduces several helpers to pass return address
> which points to the TB. Correct return address allows correct
> restoring of the guest PC and icount. These functions should be used when
> helpers embedded into TB invoke memory operations.
> 
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---
>  include/exec/cpu_ldst_template.h |   59 
> +++++++++++++++++++++++++++++++++-----
>  softmmu_template.h               |    6 ----
>  tcg/tcg.h                        |   23 +++++++++++++++
>  3 files changed, 74 insertions(+), 14 deletions(-)

This patch doesn't provide the equivalent _ra functions for the user mode
code, so it causes any linux-user target using this to fail to build. I don't
think we want to special case this kind of code in the target code, so
they need to be provided.

Otherwise it looks ok.

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
address@hidden                 http://www.aurel32.net