[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/9] Implement GIC-500
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4 2/9] Implement GIC-500 |
Date: |
Thu, 2 Jul 2015 15:42:07 +0100 |
On 2 July 2015 at 15:39, Pavel Fedin <address@hidden> wrote:
> Hello!
>
>> Hi. I'm afraid 2000 lines is really far too many to review as
>> a single patch. Please split this one up into more digestible
>> chunks.
>
> Huh... You're fast... But not fair... :( You never told the original
> author to do this:
I didn't review the original author's patchset either.
> I am sorry, i really cannot do much here, it's even not my code
> and to tell the truth i don't have enough time and knowledge to
> support it. This file is absolutely the same as in Shlomo's RFC v3,
> i haven't changed any single code line. And, it actually contains
> only a single added file by now.
If nobody splits this patch up then it is not going to get
reviewed, and so it is not going into master. I don't really
mind who does it, but somebody is going to have to...
thanks
-- PMM
[Qemu-devel] [PATCH v4 3/9] GICv3 support, Pavel Fedin, 2015/07/02
[Qemu-devel] [PATCH v4 7/9] Make use of kernel_irqchip_type in kvm_arch_irqchip_create(), Pavel Fedin, 2015/07/02
[Qemu-devel] [PATCH v4 1/9] Implement GIC-500 base class, Pavel Fedin, 2015/07/02
[Qemu-devel] [PATCH v4 2/9] Implement GIC-500, Pavel Fedin, 2015/07/02
Re: [Qemu-devel] [PATCH v4 0/9] GIC-500 implementation, software + KVM, Eric Auger, 2015/07/07